The thrift dep is indirect but required under JDK8.

Review Request #3787 — Created April 29, 2016 and submitted

jsirois
pants
jsirois/JDK8/fix_missing_dep
3303
pants-reviews
patricklaw, stuhood, zundel
Discovered here:
  http://jenkins.pantsbuild.org/job/test.pants.multibranch.pipeline/branch/PR-3292/8/execution/node/344/log/
  http://jenkins.pantsbuild.org/job/test.pants.multibranch.pipeline/branch/PR-3292/8/execution/node/392/log/

 examples/tests/java/org/pantsbuild/example/usethrift/BUILD | 1 +
 1 file changed, 1 insertion(+)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/126761621
  1. Ship It!
  2. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 9c03e0e21306b8024d861739264e2f4ded844260
Author: John Sirois <john.sirois@gmail.com>
Date:   Fri Apr 29 16:37:54 2016 -0600

    The thrift dep is indirect but required under JDK8.
    
    Discovered here:
      http://jenkins.pantsbuild.org/job/test.pants.multibranch.pipeline/branch/PR-3292/8/execution/node/344/log/
      http://jenkins.pantsbuild.org/job/test.pants.multibranch.pipeline/branch/PR-3292/8/execution/node/392/log/
    
    Testing Done:
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/126761621
    
    Bugs closed: 3303
    
    Reviewed at https://rbcommons.com/s/twitter/r/3787/
Loading...