Pin JDK8 in the pantsbuild/pants repo

Review Request #3777 — Created April 28, 2016 and discarded

stuhood
pants
2597, 3295
3799
pants-reviews
benjyw, gmalmquist, jsirois, mateor

This review proposes to pin the JDK distribution to JDK8, which is the only version supported in our OSX ci boxes, and the only version currently supported by Oracle.

  • Pin the distribution to JDK8

https://travis-ci.org/pantsbuild/pants/builds/162870441

  • 1
  • 0
  • 1
  • 0
  • 2
Description From Last Updated
Why even set MaxMetaspaceSize on all of these for java 8? We have not needed to do this at Square ZU zundel
ST
JS
  1. 
      
  2. pants.ini (Diff revision 1)
     
     
    I'm not in favor of this - we need to keep the java6 status quo until we update our floor (docs), and then this can only move to the floor.
    I think the floor discussion needs to happen on pants-devel; so I think this change should just be moved to a later RB.
    1. I'm not in favor either. We still want to run junit-runner on a java 7 jdk, for example.

  3. 
      
ST
MA
  1. Ship It!
  2. 
      
ST
ZU
  1. 
      
  2. pants.ini (Diff revision 3)
     
     

    Why even set MaxMetaspaceSize on all of these for java 8? We have not needed to do this at Square

  3. this change made me a bit nervous, but I ran the generator before and after the patch for the example code we have checked in and the output was identical other than the javadoc comments

  4. 
      
MA
  1. Ship It!
  2. We don't use jaxb so I don't really mind - but seeing a workunit block labeled 'xjc' would not mean anything to me, while I know what jaxb is (generally speaking).

  3. 
      
ST
JS
  1. 
      
  2. Broke this change out here to unblock things: https://rbcommons.com/s/twitter/r/3808/
  3. 
      
ST
ST
KW
  1. Ship It!
  2. 
      
JS
  1. Ship It!
  2. 
      
BE
  1. Ship It!
  2. 
      
MA
  1. Ship It!
  2. 
      
NH
  1. Ship It!
  2. 
      
ST
ST
Review request changed

Status: Discarded

Loading...