Fix bdist_pex to work with python2.

Review Request #3765 — Created April 26, 2016 and submitted

jsirois
pex
jsirois/issues/243
243, 246
pants-reviews
kwlzn
Previously `entry_points` handling for ini-file style only worked under
python3.  This adds tests for this narrow use case, more are needed for
other existing functionality.

 pex/commands/bdist_pex.py |  7 +++----
 pex/compatibility.py      |  8 ++++++++
 tests/test_bdist_pex.py   | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 61 insertions(+), 4 deletions(-)

Locally green: tox -epy27,py34

CI went green here:
https://travis-ci.org/pantsbuild/pex/builds/125934338

ST
  1. Ship It!
  2. 
      
JS
JS
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit a255b3ad7f0c72e6588be1059f70d14cdc94c7ce
Author: John Sirois <john.sirois@gmail.com>
Date:   Tue Apr 26 15:31:43 2016 -0600

    Fix bdist_pex to work with python2.
    
    Previously `entry_points` handling for ini-file style only worked under
    python3.  This adds tests for this narrow use case, more are needed for
    other existing functionality.
    
    Testing Done:
    Locally green: `tox -epy27,py34`
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pex/builds/125934338
    
    Bugs closed: 243, 246
    
    Reviewed at https://rbcommons.com/s/twitter/r/3765/
Loading...