convert RequestException into a more standard NonfatalArtifactCacheError

Review Request #3754 — Created April 25, 2016 and submitted April 26, 2016, 9:22 p.m.

Information
Owner:	aaron_mitchell
Repository:	pants
Branch:	fix-rest-exception
Bugs:	3266
Depends On:
Reviewers
Groups:	pants-reviews
People:	gmalmquist, patricklaw, peiyu, stuhood

Description

convert RequestException into a more standard NonfatalArtifactCacheError

Testing Done

https://travis-ci.org/pantsbuild/pants/builds/125596147

Ship it!

Hi Aaron! Could you please add some non-4sq contributors to the people field? It is best to get a cross-org consensus.

Some good candidates for this change would be peiyu and stuhood from twitter and gmalmquist from square.

People:

+	peiyu
+	stuhood
+	gmalmquist

Ship it!

```
lgtm
```
src/python/pants/cache/restful_artifact_cache.py (Diff revision 1)
```
this can probably move to after line 103.
```

Change Summary:

reduced scope of ty/except block as suggested by Peiyu

Diff:

Revision 2 (+17 -18)

Show changes

src/python/pants/cache/restful_artifact_cache.py

This has been merged to master. Please use the Close button at the top to mark this review as closed, and could you also close the pull request? Thanks Aaron!

You have a pending review.

twitter

Teams

RBCommons

convert RequestException into a more standard NonfatalArtifactCacheError

People:

Change Summary:

Diff:

Status: Closed (submitted)