convert RequestException into a more standard NonfatalArtifactCacheError
Review Request #3754 - Created April 25, 2016 and submitted
| Information | |
|---|---|
| Aaron Mitchell | |
| pants | |
| fix-rest-exception | |
| 3266 | |
| Reviewers | |
| pants-reviews | |
| gmalmquist, patricklaw, peiyu, stuhood | |
convert RequestException into a more standard NonfatalArtifactCacheError
https://travis-ci.org/pantsbuild/pants/builds/125596147
Hi Aaron! Could you please add some non-4sq contributors to the people field? It is best to get a cross-org consensus.
Some good candidates for this change would be peiyu and stuhood from twitter and gmalmquist from square.
lgtm
-
src/python/pants/cache/restful_artifact_cache.py (Diff revision 1) -
this can probably move to after line 103.
Review request changed
This has been merged to master. Please use the Close button at the top to mark this review as closed, and could you also close the pull request? Thanks Aaron!