convert RequestException into a more standard NonfatalArtifactCacheError

Review Request #3754 — Created April 25, 2016 and submitted

aaron_mitchell
pants
fix-rest-exception
3266
pants-reviews
gmalmquist, patricklaw, peiyu, stuhood
convert RequestException into a more standard NonfatalArtifactCacheError

https://travis-ci.org/pantsbuild/pants/builds/125596147

MA
  1. Hi Aaron! Could you please add some non-4sq contributors to the people field? It is best to get a cross-org consensus.

    Some good candidates for this change would be peiyu and stuhood from twitter and gmalmquist from square.

  2. 
      
AA
PE
  1. lgtm

  2. this can probably move to after line 103.

  3. 
      
AA
MA
  1. This has been merged to master. Please use the Close button at the top to mark this review as closed, and could you also close the pull request? Thanks Aaron!

  2. 
      
AA
Review request changed

Status: Closed (submitted)

Loading...