[engine] Only request literal Variants for Address objects

Review Request #3724 - Created April 19, 2016 and submitted

Information
Stu Hood
pants
3224
Reviewers
pants-reviews
kwlzn, peiyu

Variants are tied to Address objects (parsed from them), so this removes a gross inefficency by only looking up Variants for Address subjects. This is still a special case, it's just a significantly less expensive one.

Variants are well covered by tests, so this codepath is well exercised. see:
0
1
2

Unit test times before and after:

Before:
  157 passed, 1 skipped, 1 xfailed in 100.51 seconds
After:
  157 passed, 1 skipped, 1 xfailed in 35.27 seconds

https://travis-ci.org/pantsbuild/pants/builds/124283124

Peiyu Wang
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as cdcdebf95a9719bbe93fd0a3572ed91077169be4

Loading...