Write artifacts to the cache when vt.update() is called.

Review Request #3722 - Created April 19, 2016 and submitted

Information
Patrick Lawson
pants
3221
Reviewers
pants-reviews
benjyw, jsirois, mateor, stuhood, zundel

Very large zinc compiles can have thousands of targets, but the artifacts
are only written to the cache after all of them have been compiled.

Since isolated compilation guarantees us that any given target which
succeeded at compiling and which otherwise should have been cached is
safe to cache even if its downstream dependencies fail, we can instead
write these artifacts as targets finish compiling.

This has two large benefits:
1. It spreads out write-load to the artifact cache.
2. It significantly improves cache hit rate, especially with zinc's double-check, in some common CI scenarios.

This change also removes the unused invalidated() parameter use_cache.

CI is green (Jenkins)

Stu Hood
Mateo Rodriguez
Eric Ayers
Patrick Lawson
Stu Hood
Eric Ayers
Patrick Lawson
Eric Ayers
Benjy Weinberger
Benjy Weinberger
Patrick Lawson
Patrick Lawson
Patrick Lawson
Review request changed

Status: Closed (submitted)

Change Summary:

Upstream at c4787570233a87ea584771147f178f33dcf080bf

Loading...