Fix public API markers based on feedback

Review Request #3718 — Created April 18, 2016 and submitted

molsen
pants
2710, 3220
pants-reviews
benjyw, jsirois, patricklaw, stuhood, zundel
Related to comments made in https://rbcommons.com/s/twitter/r/3442/

* goals
* help
* round_engine
* fs
* invalidation

CI green: https://travis-ci.org/pantsbuild/pants/builds/124350121

BE
  1. Ship It!
  2. 
      
ZU
  1. 
      
  2. wait, we use this inside teasks (jvm_compile for instance) and we need ways for plugins to do more. We still have this hacky 'invalidate-fingerprint' job that tries to invalidate and turn off incremental compile for a target (so an annotation processor can re-run)

    1. Which methods are you currently using in your plugins that you are worried about. Could you give more context about how you are using the methods?

    2. IMO, this should still be a private API. As you pointed out, that's definitely not the recommended way to accomplish invalidation... there have been a few discussions of how to.

    3. This is the issue I'm referencing.

      https://github.com/pantsbuild/pants/issues/2532

      Again, if you want to write jvm_compile you need it, so why do you think it has to be private?

    4. Ah, you're right. I got this method confused with the other one which takes a VTS parameter.

  3. 
      
ST
  1. 
      
  2. src/python/pants/goal/context.py (Diff revision 1)
     
     
     
     
     
     
     

    I don't think there is any harm in exposing this one.

  3. 
      
MO
MO
MO
MO
ZU
  1. Ship It!
  2. 
      
MO
Review request changed

Status: Closed (submitted)

Change Summary:

commit 2162259b27d7d6b7511c009fd60888492f187086

Loading...