Fix `PEP8Error` `Nit` subclass line_range.

Review Request #3714 - Created April 18, 2016 and submitted

Information
John Sirois
pants
jsirois/issues/3188
3188, 3218
Reviewers
pants-reviews
molsen, nhoward_tw
This subclass was missed in a refactor.  Added a test that failed prior
to the fixup.

 contrib/python/src/python/pants/contrib/python/checks/tasks/checkstyle/pep8.py                    | 16 ++++++++--------
 contrib/python/tests/python/pants_test/contrib/python/checks/tasks/checkstyle/BUILD               |  1 +
 contrib/python/tests/python/pants_test/contrib/python/checks/tasks/checkstyle/plugin_test_base.py | 19 ++++++++++++++++++-
 contrib/python/tests/python/pants_test/contrib/python/checks/tasks/checkstyle/test_pep8.py        | 30 ++++++++++++++++++++++++++++++
 4 files changed, 57 insertions(+), 9 deletions(-)

Tested against Aurora repo which was failing a 0.0.82 upgrade, now works.
Locally green:
./pants test contrib/python/tests/python/pants_test/contrib/python/checks/tasks/::

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/123964202

Nick Howard (Twitter)
Matt Olsen
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 1c87851652176fe837e6c150643ea34f0ef42d91
Author: John Sirois <john.sirois@gmail.com>
Date:   Mon Apr 18 13:09:37 2016 -0600

    Fix `PEP8Error` `Nit` subclass line_range.
    
    This subclass was missed in a refactor.  Added a test that failed prior
    to the fixup.
    
    Testing Done:
    Tested against Aurora repo which was failing a `0.0.82` upgrade, now works.
    Locally green:
    `./pants test contrib/python/tests/python/pants_test/contrib/python/checks/tasks/::`
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/123964202
    
    Bugs closed: 3188, 3218
    
    Reviewed at https://rbcommons.com/s/twitter/r/3714/
Loading...