Fix ProgressListener % progress.

Review Request #3712 — Created April 17, 2016 and submitted

jsirois
pants
jsirois/fetcher/fix_percent_complete
3216
pants-reviews
gmalmquist, nhoward_tw
Previously int conversion was happening too early leading to a stuck 0%.

 src/python/pants/net/http/fetcher.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Manually ran ./pants clean-all test.node contrib/node/examples::
Several times until stopped by rate-limits (see:
https://rbcommons.com/s/twitter/r/3710/)

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/123784467

JS
  1. Looks like this broke here: https://github.com/pantsbuild/pants/commit/9514990ef3d6e24aaa747e96ed4069cf4e43824a#diff-b2ace45654fc42421aa92079660e67fd
  2. 
      
JS
WI
  1. Ship It!
    1. Thanks for the review - I'm going to go ahead and submit.
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 78b8875fd1ed66037cb659233e270761c400ec65
Author: John Sirois <john.sirois@gmail.com>
Date:   Mon Apr 18 09:43:29 2016 -0600

    Fix ProgressListener % progress.
    
    Previously int conversion was happening too early leading to a stuck 0%.
    
    Testing Done:
    Manually ran `./pants clean-all test.node contrib/node/examples::`
    Several times until stopped by rate-limits (see:
    https://rbcommons.com/s/twitter/r/3710/)
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/123784467
    
    Bugs closed: 3216
    
    Reviewed at https://rbcommons.com/s/twitter/r/3712/
Loading...