Use requests/Fetcher to fetch Node pre-installed's.

Review Request #3711 - Created April 18, 2016 and submitted

Information
John Sirois
pants
jsirois/node/use_requests
3215
3710
Reviewers
pants-reviews
gmalmquist, stuhood
contrib/node/src/python/pants/contrib/node/subsystems/resolvers/node_preinstalled_module_resolver.py | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

Locally green:

./pants clean-all test.node contrib/node/examples::
...
16:24:54 00:00   [resolve]
16:24:54 00:00     [ivy]
16:24:54 00:00       [cache].
16:24:54 00:00       [bootstrap-nailgun-server]
16:24:55 00:01     [go]
16:24:55 00:01     [scala-js-compile]
16:24:55 00:01     [scala-js-link]
16:24:55 00:01     [node]
                   Invalidated 5 targets.INFO] Downloading archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmp4_TQfD/node_modules.tar.gz
100% .................................................. 2070 KB 3.365s
INFO] Fetched archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmp4_TQfD/node_modules.tar.gz
...

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/123786928

John Sirois
John Sirois
Eric Ayers
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 7c0a5eb95efbb0e3e7ca2619cb071f5f5dd748e3
Author: John Sirois <john.sirois@gmail.com>
Date:   Mon Apr 18 09:42:53 2016 -0600

    Use requests/Fetcher to fetch Node pre-installed's.
    
    Testing Done:
    Locally green:
    ```
    ./pants clean-all test.node contrib/node/examples::
    ...
    16:24:54 00:00   [resolve]
    16:24:54 00:00     [ivy]
    16:24:54 00:00       [cache].
    16:24:54 00:00       [bootstrap-nailgun-server]
    16:24:55 00:01     [go]
    16:24:55 00:01     [scala-js-compile]
    16:24:55 00:01     [scala-js-link]
    16:24:55 00:01     [node]
                       Invalidated 5 targets.INFO] Downloading archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmp4_TQfD/node_modules.tar.gz
    100% .................................................. 2070 KB 3.365s
    INFO] Fetched archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmp4_TQfD/node_modules.tar.gz
    ...
    ```
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/123786928
    
    Bugs closed: 3215
    
    Reviewed at https://rbcommons.com/s/twitter/r/3711/
Loading...