Point Node preinstalled-project at a better URL.

Review Request #3710 - Created April 17, 2016 and submitted

Information
John Sirois
pants
jsirois/node/stable_node_preinstalled_modules_server
3214
3711
Reviewers
pants-reviews
gmalmquist, stuhood, zundel
The bintray repo is not subject to the rate-limiting of the github
serving and is generally designed for the job.

 contrib/node/examples/src/node/preinstalled-project/BUILD | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Locally green:

./pants test.node contrib/node/examples::
...
16:08:02 00:00   [resolve]
16:08:02 00:00     [ivy]
16:08:02 00:00     [go]
16:08:02 00:00     [scala-js-compile]
16:08:02 00:00     [scala-js-link]
16:08:02 00:00     [node]
                   Invalidated 1 target.INFO] Downloading archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmpQLRr5M/node_modules.tar.gz
INFO] Fetched archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmpQLRr5M/node_modules.tar.gz

16:08:06 00:04   [resources]
...

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/123777949

John Sirois
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit bf087c4433a29e2e8d09fd48ec70e601bd46423c
Author: John Sirois <john.sirois@gmail.com>
Date:   Mon Apr 18 13:07:45 2016 -0600

    Point Node preinstalled-project at a better URL.
    
    The bintray repo is not subject to the rate-limiting of the github
    serving and is generally designed for the job.
    
    Testing Done:
    Locally green:
    ```
    ./pants test.node contrib/node/examples::
    ...
    16:08:02 00:00   [resolve]
    16:08:02 00:00     [ivy]
    16:08:02 00:00     [go]
    16:08:02 00:00     [scala-js-compile]
    16:08:02 00:00     [scala-js-link]
    16:08:02 00:00     [node]
                       Invalidated 1 target.INFO] Downloading archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmpQLRr5M/node_modules.tar.gz
    INFO] Fetched archive node_modules.tar.gz from https://dl.bintray.com/pantsbuild/node-preinstalled-modules/node_modules.tar.gz to /tmp/tmpQLRr5M/node_modules.tar.gz
    
    16:08:06 00:04   [resources]
    ...
    ```
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/123777949
    
    Bugs closed: 3214
    
    Reviewed at https://rbcommons.com/s/twitter/r/3710/
John Sirois
Submitted this by mistake when trying to really submit https://rbcommons.com/s/twitter/r/3714/
I'll circle back if there are any objections.
Stu Hood
Ship It!
Loading...