bootstrap ivy option
Review Request #3700 — Created April 15, 2016 and submitted
Bootstrap Ivy Settings option
Use a separate Ivy settings for bootstrapping Ivy itself. This way you can get external resolvers (like the S3 one in that issue) and avoid the chicken-and-egg problem.
See also https://github.com/pantsbuild/pants/pull/3204
My comment on this is that if I have --ivy-settings set but not --bootstrap-ivy-settings set, I would like for the bootstrapper to use the --ivy-settings.xml file we have.
In our case, our ivy settings is overridden to make sure we only fetch packages from our internal artifact manager (we don't want it to go out to the Internet). With this change the first fetch will silently use a default template.
I think the change would be simple:
ivy_settings=self._ivy_subsystem.get_options().bootstrap_ivy_settings or self._ivy_subsystem.get_options().ivy_settings,
It would be great to get some kind of test in place for this, but I don't want to put all that on you, and it really is just a simple options plumbing issue.
I see that this passed the ci builder at: https://travis-ci.org/pantsbuild/pants/builds/123504708
I'll give John some time to respond, otherwise ping me on Monday and I'll upstream this.
Thanks for the patch Nitay! Commited to master @ 2f4abfa
COuld you please mark this reviw as 'submitted' in rbcommons and close the associated github issues/PR?