bootstrap ivy option

Review Request #3700 — Created April 15, 2016 and submitted

nitayj
pants
3174
pants-reviews
jsirois, zundel

Bootstrap Ivy Settings option

Use a separate Ivy settings for bootstrapping Ivy itself. This way you can get external resolvers (like the S3 one in that issue) and avoid the chicken-and-egg problem.

See also https://github.com/pantsbuild/pants/pull/3204

  1. 
      
  2. src/python/pants/ivy/bootstrapper.py (Diff revision 2)
     
     

    My comment on this is that if I have --ivy-settings set but not --bootstrap-ivy-settings set, I would like for the bootstrapper to use the --ivy-settings.xml file we have.

    In our case, our ivy settings is overridden to make sure we only fetch packages from our internal artifact manager (we don't want it to go out to the Internet). With this change the first fetch will silently use a default template.

    I think the change would be simple:

                   ivy_settings=self._ivy_subsystem.get_options().bootstrap_ivy_settings or self._ivy_subsystem.get_options().ivy_settings,
    
    1. makes sense, will do

  3. 
      
  1. Ship It!
  2. 
      
  1. It would be great to get some kind of test in place for this, but I don't want to put all that on you, and it really is just a simple options plumbing issue.

    I see that this passed the ci builder at: https://travis-ci.org/pantsbuild/pants/builds/123504708

    I'll give John some time to respond, otherwise ping me on Monday and I'll upstream this.

  2. 
      
  1. 
      
  2. src/python/pants/ivy/ivy_subsystem.py (Diff revision 3)
     
     
     
     

    Mind marking both of these fingerprint=True and type=file_option ?

    1. This changes the caching policy which might be a change for the better, but wasn't the point of this change. I went ahead and submitted the change without this fix if you want to follow up and add them.

  3. 
      
  1. Thanks for the patch Nitay! Commited to master @ 2f4abfa

    COuld you please mark this reviw as 'submitted' in rbcommons and close the associated github issues/PR?

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...