Have all JvmToolMixins share the same --jvm-options option registration.

Review Request #3684 — Created April 11, 2016 and submitted

benjyw
pants
pants-reviews
nhoward_tw, patricklaw, stuhood, zundel

It was pointlessly repeated everywhere. This change means that
(in a followup change) we can set a generally useful default once
for all tasks (e.g., memory settings, encoding and timezone), with
subclasses overriding as needed.

Also, took this opportunity to clarify in docstrings the distinction
between JvmTask and JvmToolTaskMixin.

CI passes: https://github.com/pantsbuild/pants/pull/3178

  1. Ship it! I especially like the extended docstrings!

  2. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

a68290cf748d4871fc80721c0b127320d5861895

  1. Submitted! Thanks Nick and Eric.

  2. 
      
Loading...