Change some option defaults.

Review Request #3678 — Created April 10, 2016 and submitted

benjyw
pants
pants-reviews
gmalmquist, mateor, nhoward_tw, patricklaw, stuhood, zundel

These are based on common pants.ini configs at Square, Foursquare and Twitter.

The nature of these options is such that changing the default is unlikely to have
adverse impact on anyone not currently setting them explicitly in pants.ini,
and we'd like to make them more useful before we freeze them in 1.0.

But please verify that these won't hurt your org.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/122111992

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
  1. Ship It!
  2. 
      
  1. 
      
  2. I'm not so sure that -Duser.timezone=UTC is a universally wanted thing. Yes, in a big shop where you are running a cloud service but maybe not everywhere.

    1. What is that setting actually for? Without this will Java take the timezone from the system its running on?

    2. Yes, I think that's it. We use it to make sure that our unit tests get consistent results and to make sure our database timestamps all agree.

    3. So it sounds like it's good practice to fix this to something, and that something should almost certainly be UTC, but I agree that I'm not sure if we want to make that the default. I'll remove it for now.

  3. Could you fix this while you are in here? The help here should say that these are glob patterns. .* seems awful if it was a regular expression.

  4. 
      
  1. 
      
  2. UTC is a reasonable default, imo.

  3. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

60298ec6e85a11dd70138f2902ab4c911a7282e5

Loading...