Use ssh auth when publishing docs.

Review Request #3676 — Created April 10, 2016 and discarded

patricklaw
pants
3171
pants-reviews
benjyw, jsirois, kwlzn, stuhood, zundel
Use ssh auth when publishing docs.

CI is baking: https://travis-ci.org/pantsbuild/pants/builds/122104366

I used this diff to publish the docs for the 0.0.81 release.

ST
  1. Kris changed this recently because github recommends https auth by default. Either way is probably fine.

    1. Mind including him on this review though?

    2. It was Kris Wilson who changed it. I had questions about it when I went to run the publishing job the next time around. I use ssh everywhere else I'm fine with it.

    3. Done.

  2. 
      
LA
  1. Ship It!
  2. 
      
BE
  1. Why?

    1. Every time I run the release I have to make this patch to get the documentation publishing to work. It seems weird to me to not use ssh when pushing to a git repo.

    2. it is very easy to add an auth token and stop caring about this issue

      https://help.github.com/articles/creating-an-access-token-for-command-line-use/

      then add to .netrc:

      machine github.com
       login ericzundel
       password ou812
      
  2. 
      
PA
KW
  1. Ship It!
  2. 
      
PA
Review request changed

Status: Discarded

Change Summary:

(Its pretty easy to use http auth with a github token if you run into this again)

Loading...