Prepare the 0.0.81 release.

Review Request #3673 — Created April 9, 2016 and submitted

patricklaw
pants
3165
pants-reviews
benjyw, jsirois, peiyu, zundel
Prepare the 0.0.81 release.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/122087363

  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
PA
PA
PE
  1. Saw a few more marked deprecated_conditional 0.0.81 in https://github.com/pantsbuild/pants/blob/master/src/python/pants/option/parser.py#L299-L329

    should we extend or deprecate them?

    1. Discussed this with Benjy in chat: it seems okay to leave them in for now (I think this just makes them fatal), and he's going to remove them this coming week. Apparently we can't just remove them; they need to be translated into hard errors.

    2. I'd say for now just bump those to 0.0.83 and I'll get rid of them along with the rest of of the 0.0.83 options deprecations in a couple of weeks. It will be easier to do them all in one go anyway.

    3. I'm fine with just bumping them to the next release or two.

    4. Okay, bumping those to 83 and then proceeding with the release.

  2. 
      
PE
  1. Ship It!
  2. 
      
ZU
  1. Ship It!
  2. 
      
ZU
  1. 
      
  2. apparently this was still referenced in code:

                       ==================== FAILURES ====================
                         _ IvyUtilsGenerateIvyTest.test_symlink_cachepath _
    
                         self = <pants_test.backend.jvm.tasks.test_ivy_utils.IvyUtilsGenerateIvyTest testMethod=test_symlink_cachepath>
    
                             def test_symlink_cachepath(self):
                               self.maxDiff = None
                               with temporary_dir() as mock_cache_dir:
                                 with temporary_dir() as symlink_dir:
                                   with temporary_dir() as classpath_dir:
                                     input_path = os.path.join(classpath_dir, 'inpath')
                                     output_path = os.path.join(classpath_dir, 'classpath')
                                     foo_path = os.path.join(mock_cache_dir, 'foo.jar')
                                     with open(foo_path, 'w') as foo:
                                       foo.write("test jar contents")
    
                                     with open(input_path, 'w') as inpath:
                                       inpath.write(foo_path)
                         >           result_map = IvyUtils.symlink_cachepath(mock_cache_dir, input_path, symlink_dir,
                                                                             output_path)
                         E           AttributeError: type object 'IvyUtils' has no attribute 'symlink_cachepath'
    
                         tests/python/pants_test/backend/jvm/tasks/test_ivy_utils.py:347: AttributeError
    
    1. Yeah, I mentioned this in Slack. I'm holding this build until this is taken care of--I'm not comfortable ripping out or rewriting tests wholesale just to push forward a release.

    2. Here's a PR that updates the test and removes the deprecations. The nwe method is very close to the old method. https://rbcommons.com/s/twitter/r/3675/

    3. That change has been submitted.

  3. 
      
BE
  1. 
      
  2. src/python/pants/CHANGELOG.rst (Diff revision 2)
     
     

    I wasn't following the file lock changes, but are these literally the file names, in the root? If so, why aren't these under .pants.d, and so ignored anyway? This seems like another hoop to make new installs jump through, no?

    1. Yes, they are. That option was discussed in the PR where this change was made, but we decided that it was too large of a departure from the existing implementation for that particular change. It's probably what we should do going forward, though.

    2. Yeah, it seems unfortunate to require yet another .gitignore change.

    3. Okay, barring some immediate action you want to take on this, I'm going to drop the issue. I don't see this as a release blocker, and it's also not something that should be shoe-horned into the release itself.

    4. I agree.

  3. Shouldn't there be changes in parser.py?

PA
PA
PA
PA
Review request changed

Status: Closed (submitted)

Change Summary:

Upstream at ba99c2dc606f83b768965a494e19aeb560e8fa6b

Loading...