Rename the global lock from pants.run to pants.workdir.file_lock

Review Request #3668 — Created April 8, 2016 and submitted

zundel
pants
zundel/rename-global-lock-file
3163
800c5d0...
pants-reviews
kwlzn, nhoward_tw, patricklaw, stuhood

This change renames the global lock in pants to keep it from conflicting with implementations prior to https://rbcommons.com/s/twitter/r/3633/

In prior implementations (using the python lockfile module) the presence of the file itself signals the lock.
After the change to use OwnerPrintingInterProcessFileLock which uses the fastener's library, the file will be left behind after the lock
is released. This causes problems if you later invoke an older version of pants in a workspace after using the updated version of pants
(for example, which switching back to an older branch in the repo.)

CI is running at https://travis-ci.org/pantsbuild/pants/builds/121803515

  1. Ship It!
  2. 
      
  1. Ship It!
  2. 
      
  1. Ship It!
  2. 
      
  1. #shipit for a rename

    (but "global" in the name implies the wrong thing... this isn't a global lock: it's a workspace lock)

    1. ...and more than that, it's a lock specific to the workdir/dist directories.

  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks all. Commit e8f4b7f

Loading...