Thanks! Another excellent cleanup.
Would you mind updating http://pantsbuild.github.io/dev_tasks.html#fine-tuning-options for these changes? Looks like
appendis still mentioned there as well.
Replace all action='store_true' options with type=bool.
Review Request #3661 — Created April 7, 2016 and submitted
|gmalmquist, mateor, nhoward_tw|
Almost entirely mechanical change. action='store_true' was
implemented by converting to type=bool under the covers anyway,
so this wasn't expected to be a disruptive change.
The interesting parts are under
CI passes: https://travis-ci.org/pantsbuild/pants/builds/121499713
Update options documentation page.
Thanks Stu! Submitted as 9f2bd17640a29ee7ad34d353efdd979222a75f70.
I just noticed this review and I am retroactively happy about it!