Replace all action='store_true' options with type=bool.

Review Request #3661 — Created April 7, 2016 and submitted

benjyw
pants
pants-reviews
gmalmquist, mateor, nhoward_tw

Almost entirely mechanical change. action='store_true' was
implemented by converting to type=bool under the covers anyway,
so this wasn't expected to be a disruptive change.

The interesting parts are under src/python/pants/option
and tests/python/pants_test/option

CI passes: https://travis-ci.org/pantsbuild/pants/builds/121499713

  1. Thanks! Another excellent cleanup.

    Would you mind updating http://pantsbuild.github.io/dev_tasks.html#fine-tuning-options for these changes? Looks like append is still mentioned there as well.

  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

9f2bd17640a29ee7ad34d353efdd979222a75f70

  1. Thanks Stu! Submitted as 9f2bd17640a29ee7ad34d353efdd979222a75f70.

  2. 
      
  1. Ship It!
  2. 
      
  1. I just noticed this review and I am retroactively happy about it!

  2. 
      
Loading...