Import zincutils

Review Request #3657 — Created April 6, 2016 and submitted

stuhood
pants
3156
pants-reviews
benjyw, gmalmquist, patricklaw, peiyu

Re-import zincutils in order to make it easier to change. The motivation for moving this out was that this code might be ported to native code, which would be easier accomplished externally. That turned out to be unnecessary, and there are upcoming changes to the zinc/sbt version used in the pants repo that are more easily accomplished and tested with our full test suite in place.

This was roughly:
- cp zincutils/zincutils src/python/pants/backend/jvm/zinc
- cp zincutils/tests to tests/python/pants_test/backend/jvm/zinc
- Fixup imports, apply style fixes.

https://travis-ci.org/pantsbuild/pants/builds/121269857

  1. 
      
  2. fix reference to zincutils

    there are two other places in analysis_tools.py

    src/python/pants/backend/jvm/tasks/jvm_compile/analysis_tools.py:      # TODO: Change to one call to zincutils when API will be made: https://github.com/pantsbuild/zincutils/issues/8.
    src/python/pants/backend/jvm/tasks/jvm_compile/analysis_tools.py:      # TODO: Change to one call to zincutils when API will be made: https://github.com/pantsbuild/zincutils/issues/8.
    
  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 5c1649799a14e9f19b449874c0a2e5390b1a2a8a

Loading...