Add Public API markers for ivy and java APIs

Review Request #3655 — Created April 6, 2016 and submitted

molsen
pants
2710, 3145
3752
pants-reviews
fkorotkov, gmalmquist, jsirois, nhoward_tw, stuhood, zundel

Set public API markers for ivy and java

The following modules were reviewed and all api's were left as private. As
far as I can tell these modules are not currently used by plugins.

  • src/python/pants/ivy/bootstrapper.py
  • src/python/pants/ivy/ivy.py
  • src/python/pants/java/jar/manifest.py
  • src/python/pants/java/nailgun_client.py
  • src/python/pants/java/nailgun_executor.py
  • src/python/pants/java/nailgun_io.py
  • src/python/pants/java/nailgun_protocol.py
  • src/python/pants/java/util.py
  • src/python/pants/logging/setup.py
  • src/python/pants/net/http/fetcher.py

CI pending: https://travis-ci.org/pantsbuild/pants/builds/121305458

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. Ship It!
  2. 
      
  1. Ship it!

  2. If this is public, should the Distribution class be public as well?

    1. This was marked as public because its being used by Square based on https://github.com/pantsbuild/pants/issues/2587

      If they could weigh in for context that may be helpful. If this isn't really needed as a public API we can remove it.

    2. SubprocessExecutor which is public requires a distribution to run ... marking public

  3. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

commit 2916531f60efeeaf70062c556b9188ddee3e6bee

Loading...