Add --delete-lock-on-release to help users transition to file locking.

Review Request #3650 — Created April 5, 2016 and discarded

patricklaw
pants
3143
3652, 3666, 3638
pants-reviews
benjyw, wisechengyi, zundel

The option defaults to false and only applies to the pants "global" workspace lock.
Since the name of the ivy resolution lock changed with the switch to file locking,
the ivy subsystem does not need an equivalent option.

CI is baking: https://travis-ci.org/pantsbuild/pants/builds/120902254

Added a unit test and manually confirmed that setting delete_lock_on_release: True
in pants.ini removes the lock after a run completes.

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
This should probably explain how it facilitates that transition... is the idea that you need to delete this lock file ... ST stuhood
ST
  1. 
      
  2. src/python/pants/option/global_options.py (Diff revision 1)
     
     
     
     
     
     

    This should probably explain how it facilitates that transition... is the idea that you need to delete this lock file if you want to downgrade to older versions?

    Should this be turned on by default, but be deprecated immediately?

    1. It's not clear to me that most shops need this, and if we do an immediate deprecation then the default shouldn't be to enable the now-deprecated option.

    2. As far as explaining it--can you suggest a better wording? I feel like this help message explains what's going on pretty clearly.

    3. We do need it, but only short term. I would be happy with an immediate deprecation.

    4. Wait, I'm not OK with immediately deprecating it because we're going to get an error every time we run pants. I need to keep this option set long enough so that I know folks aren't going to be developing on old releases (a month or two)

    5. Proposing https://rbcommons.com/s/twitter/r/3668/ as an alternative (simply renames the global lock file name like we did for the ivy lock)

  3. 
      
ZU
  1. Ship It!
  2. 
      
PA
Review request changed

Status: Discarded

Change Summary:

This didn't seem particularly safe; instead we settled on changing the lock path

Loading...