[engine] Move the visualizer into LocalScheduler.

Review Request #3649 — Created April 5, 2016 and submitted

kwlzn
pants
kwlzn/engine/scheduler_viz
3138, 3141
pants-reviews
peiyu, stuhood
  • Migrate the meat of the visualizer into LocalScheduler.visualize_graph.
  • Add basic tests for coverage.

https://travis-ci.org/pantsbuild/pants/builds/120774094

+ local testing against viz and viz-fs.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. 
      
  2. this appears lost with the code move

  3. 
      
  1. 
      
  2. src/python/pants/engine/exp/scheduler.py (Diff revision 1)
     
     
     
     

    This method probably isn't performance critical enough to warrant making these true constants... can probably declare them in the method.

  3. This feels like a method that should be on ProductGraph, whereas visualize_graph_to_file could probably stay on Scheduler.

  4. Should this be acquiring the lock?

    1. good call - fixed.

  5. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

thanks Peiyu & Stu! submitted @ f01c2c674c1c2055e6d98e3dea66d00770082a0c

Loading...