Fix #3132: `./pants changed` doesn't fail on changed invalid `BUILD` files

Review Request #3646 — Created April 4, 2016 and submitted

tabishev
pants
tabishev/fix_3132
3137
pants-reviews
kwlzn, patricklaw, qma, stuhood, zundel

This PR fixes issue #3132: "pants changed" should fail but does not on changed invalid BUILD file.

https://travis-ci.org/ttim/pants/builds/120646709

  1. Ship It!
  2. 
      
  1. Ship It!
  2. 
      
  1. Thanks for fixing. This now properly raises AddressLoopupError. How about BuildFileAddressMapper.BuildFileScanError? what scenario would trigger that, and should that be raised and fail the task as well?

    1. Currently the only scenario which triggers BuildFileScanError in this code if there is no buildfiles at spec_path. This behaviour is similar to what we had before.

      I don't like this use-exceptions-for-control-flow but I think it's ok as short term fix, for long term perspective new engine looks like a better place.

  2. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as c10e20c8dfab9ec886c2dfa48c695f62ec569039

Loading...