Process 0.0.80 deprecation removals.

Review Request #3639 - Created April 1, 2016 and submitted

Information
John Sirois
pants
jsirois/0.0.80/process_removals
3127
Reviewers
pants-reviews
benjyw, patricklaw, zundel
Options:

`--scala-platform-runtime`:
Option is no longer used, `--version` is used to specify the major
version. The runtime is created based on major version. The runtime
target will be defined at the address `//:scala-library` unless it is
overriden by the option `--runtime-spec` and a `--version` is set to
custom.

`--spec-excludes`:
Use `--ignore-patterns` instead. Use .gitignore syntax for each item, to
simulate old behavior prefix each item with "/".

`PANTS_DEFAULT_*`:
Use `PANTS_GLOBAL_*` instead of `PANTS_DEFAULT_*`

BUILD Files:

`python_requirement(..., version_filter):`
The version_filter argument has been removed with no replacement.

 src/python/pants/backend/jvm/subsystems/scala_platform.py |  9 ---------
 src/python/pants/backend/python/BUILD                     |  3 ---
 src/python/pants/backend/python/python_requirement.py     | 21 ++++-----------------
 src/python/pants/option/global_options.py                 |  7 -------
 src/python/pants/option/options.py                        | 10 +++++-----
 src/python/pants/option/parser.py                         |  5 +----
 6 files changed, 10 insertions(+), 45 deletions(-)

The ./build-support/bin/ci.sh ran green locally (mod known issues iiuc:
+ cloc vs too-new perl
+ java distribution test issues vs a healthy set of java envs:

$ archlinux-java status
Available Java environments:
  java-6-jdk
  java-7-jdk
  java-7-openjdk
  java-8-jdk
  java-8-openjdk (default)
  java-9-jdk 

).

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/120097720

Patrick Lawson
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 3dab6e6baf3be3c652f0dd8a0e41c799b470f593
Author: John Sirois <john.sirois@gmail.com>
Date:   Fri Apr 1 10:28:32 2016 -0600

    Process 0.0.80 deprecation removals.
    
    Options:
    
    `--scala-platform-runtime`:
    Option is no longer used, `--version` is used to specify the major
    version. The runtime is created based on major version. The runtime
    target will be defined at the address `//:scala-library` unless it is
    overriden by the option `--runtime-spec` and a `--version` is set to
    custom.
    
    `--spec-excludes`:
    Use `--ignore-patterns` instead. Use .gitignore syntax for each item, to
    simulate old behavior prefix each item with "/".
    
    `PANTS_DEFAULT_*`:
    Use `PANTS_GLOBAL_*` instead of `PANTS_DEFAULT_*`
    
    BUILD Files:
    
    `python_requirement(..., version_filter):`
    The version_filter argument has been removed with no replacement.
    
    Testing Done:
    The `./build-support/bin/ci.sh` ran green locally (mod known issues iiuc:
    + cloc vs too-new perl
    + java distribution test issues vs a healthy set of java envs:
    ```
    $ archlinux-java status
    Available Java environments:
      java-6-jdk
      java-7-jdk
      java-7-openjdk
      java-8-jdk
      java-8-openjdk (default)
      java-9-jdk
    ```
    ).
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/120097720
    
    Bugs closed: 3127
    
    Reviewed at https://rbcommons.com/s/twitter/r/3639/
Benjy Weinberger
Ship It!
Loading...