lgtm. I'll reassert my position that it still feels odd/cluttered to colocate configuration with code (re: the re-embedding of the
register.pyconfiguration bits) - I'd much rather see the implementation clean/free of configuration and lean toward a model where those are imported in configuration-specific modules, but don't feel strongly enough about it to block.
[engine] Package cleanup: round one
Review Request #3622 — Created March 28, 2016 and submitted
|kwlzn, patricklaw, peiyu|
- Extract example parsers into
example, leaving only the interfaces in
- Remove the
selectorsto make the selectors package very, very light
- With the
nodesissue resolved, remove
registermodules in favor of defining tasks at finer granularity whereever their implementations live
example, since it is only used by the example planners
Fix import/eval errors from CI.
Revision 2 (+239 -266)