Support type=list and type=dict in option registration.

Review Request #3618 — Created March 26, 2016 and submitted

benjyw
pants
pants-reviews
mateor, nhoward_tw, stuhood, zundel

This allows option registration code to do what comes naturally,
and not have to import, or depend on, pants.option.

- Deprecates explicit specification of list_option, dict_option
- Deprecates action='append', as it's the same as list_option.

Note: The interesting bits of this review are the ones under
src/python/pants/option/parser.py and tests/python/pants_test/option.
Everything else is mechanical, done by sed script.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/118722799

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
BE
BE
MA
  1. 
      
  2. src/python/pants/option/parser.py (Diff revision 1)
     
     

    I think you mean dict_option here.

    1. Oops yes, I certainly do.

  3. 
      
MA
  1. Oops, forgot to hit the Ship It button - excepting my comment above.
  2. 
      
BE
BE
ZU
  1. This is great!

  2. 
      
BE
  1. Submitted as c690c08b846f368ccbfcdde63a1ff6964c3a4d74. Thanks!

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

c690c08b846f368ccbfcdde63a1ff6964c3a4d74

Loading...