Only mark a build incremental if it is successfully cloned

Review Request #3613 - Created March 25, 2016 and submitted

Information
Stu Hood
pants
3087, 3094
Reviewers
pants-reviews
molsen, patricklaw, zundel

Fix handling in case of a Task.implementation_version change. The task implementation version intentionally changes the directory in an unstable way, but the handling of incremental builds in that case would still mark the build is_incremental=True, which tasks might attempt to use and then fail.

  • Only mark a VT incremental if the previous directory was successfully cloned.
  • Test implementation version changes explicitly.

https://travis-ci.org/pantsbuild/pants/builds/118525210

Matt Olsen
Nick Howard (Twitter)
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 08dbecc1ce5266ee509ed0684d1d6f52f220b4d9

Loading...