Allow a period in a namedver for publishing

Review Request #3611 — Created March 25, 2016 and submitted

zundel
pants
zundel/allow-periods-namedver
3092
3c27df1...
pants-reviews
benjyw, gmalmquist, jsirois, patricklaw, stuhood

I loosened up the naming restrictions to allow a period. At Square we have an existing convention for some projects that looks like project-1.2.3. It doesn't match semver, so I don't think it will conflict with any other publishing.

Namedver is pretty restrictive on naming. I tried to capture the reason behind it in some comments.

CI running at https://travis-ci.org/pantsbuild/pants/builds/118453831

Added some more unit tests.

  1. Ship It!
  2. 
      
  1. 
      
  2. Can you fixup the message here? Maybe just str the regex itself.

  3. 
      
  1. 
      
  2. src/python/pants/task/scm_publish_mixin.py (Diff revisions 1 - 2)
     
     

    now displays:
    E ValueError: Named versions must match ^[-_.A-Za-z0-9]+$: 'Foo*'

  3. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Stu and Garrett. Commit 5797a7c

Loading...