[engine] no longer content address subject
Review Request #3604 — Created March 24, 2016 and submitted
|kwlzn, patricklaw, stuhood|
TL;DR: no longer CA subject, CA nodes but will be smart about it in the next
Still part of , at present we CA 100%, subject is sth we can save, because
the only way for a task to view a subject is by
Selecting it and in that case
it will be CA-ed as
While we remove subject from CA, because  we would have to either make all
subjects orderable (certainly a big restriction and not preferred) or CA the
node itself. This review does the latter. The next review will make CA nodes
(as well as other things) only happen when they are for caching or for
Other changes included:
- Overwrite default
AddressMapper.__repr__, so when it is subject, in debug
mode, it doesn't have machine address, that results cache misses.
Nodeis content address-ed in
Scheduler, which might be questionable.
Previous thinking is to have scheduler stay out of CA business, this can
still be achived by having an additional conversion in Engine, we can revisit
if there is such a need.
- No more special handling of cyclic
Noop, previousely due to scheduler
Statebut it doesn't do CA now it does
 Content address performance https://github.com/pantsbuild/pants/issues/3066
 Randomness as in https://rbcommons.com/s/twitter/r/3593/
Address review comment - print cache stats to stderr.