update pyflakes to 1.1.0, enable pyflakes checks and fix all warnings

Review Request #3601 - Created March 24, 2016 and submitted

Information
Chris Heisterkamp
pants
enable-pyflakes
3077
Reviewers
pants-reviews
gmalmquist, jsirois, nhoward_tw, patricklaw, stuhood, zundel
update pyflakes to 1.1.0, enable pyflakes checks and fix all warnings

Travis CI: https://travis-ci.org/pantsbuild/pants/builds/118569830

Enable PyFlakes https://pypi.python.org/pypi/pyflakes which claims: "it will never complain about style, and it will try very, very hard to never emit false positives."

This change enables all of the pyflakes checks documented at http://flake8.readthedocs.org/en/latest/warnings.html.

By far most of the fixes in this change are for unused imports but it did find several tests that had duplicate names, several unused variables and variables that were not defined.

Issues

  • 0
  • 4
  • 1
  • 5
Description From Last Updated
Eric Ayers
Mateo Rodriguez
Garrett Malmquist
Chris Heisterkamp
Stu Hood
Nick Howard (Twitter)
Chris Heisterkamp
Eric Ayers
Chris Heisterkamp
Eric Ayers
Chris Heisterkamp
Review request changed

Status: Closed (submitted)

Loading...