Validate command line options regardless whether goals use them.

Review Request #3594 - Created March 22, 2016 and submitted

Information
Yi Cheng
pants
2254
Reviewers
pants-reviews
benjyw, nhoward_tw, patricklaw, stuhood, zundel

Earlier command line options are not parsed/validated unless used by the goals.
E.g. ./pants bundle --jvm-invalid does not error. This change proactively validates the command line options.

The performance impact is minimal:

[tw-mbp-yic pants (master)]$ time for i in `seq 20`;do ./pants goals --jvm-bundle-archive=zip ; done &> /dev/null 

real    0m12.918s
user    0m8.556s
sys 0m4.429s

[tw-mbp-yic pants (silent_arg_fix)]$ time for i in `seq 20`;do ./pants goals --jvm-bundle-archive=zip ; done &> /dev/null 

real    0m12.943s
user    0m8.429s
sys 0m4.370s

Green: https://travis-ci.org/wisechengyi/pants/builds/117776861

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Eric Ayers
Stu Hood
Yi Cheng
Yi Cheng
Review request changed

Status: Closed (submitted)

Change Summary:

0574386aa74a5fea17ad211329ecdfd77e894b9b

Thanks everyone!

Loading...