[engine] Calculate legacy target sources using the engine

Review Request #3592 - Created March 21, 2016 and submitted

Information
Stu Hood
pants
3058, 3076
Reviewers
pants-reviews
dturner-tw, gmalmquist, kwlzn, peiyu

This review replaces sources fields on targets reified in the ExpGraph with a helper object that creates a FilesetWithSpec that uses the engine to compute the Paths and FileContent. This means that once construction of the Graph switches over, all BUILD files and source hashes will be cached.

This is in support of #3058.

  • Replace glob implementations with capturing implementations and create FilesetWithSpecs.
  • Add filemap legacy command to demonstrate that we are able to compute paths.
  • Mutate a single ParseContext in LegacyParser rather than recreating for each path.
  • Normalize SourcesField to always consume a FilesetWithSpec object.
  • Move the implementation of file-content fetching to FilesetWithSpec, to allow our alternate implementation to use the engine to get FileContent.
  • Finished removing num_chunking_units (after r/3474), which was forcing sources in cases where we otherwise didn't need to.

https://travis-ci.org/pantsbuild/pants/builds/118376108

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Kris Wilson
Peiyu Wang
Stu Hood
David Turner
Stu Hood
Stu Hood
Stu Hood
Stu Hood
Matt Olsen
Kris Wilson
Stu Hood
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 1c7de069b54c4fde261b0cf7d099cbd0060f73ad

Loading...