Fix `compute_hashes` for `Page` target type

Review Request #3591 — Created March 21, 2016 and submitted

tabishev
pants
tabishev/wikipage_hash_issue
3069
pants-reviews
benjyw, molsen, patricklaw, stuhood, zundel

I've discovered fingerprint method fails on Page targets because WikiArtifact doesn't contain fingerprint method. This PR contains tests for WikiArtifact payload fingerprint and fix for it.

https://travis-ci.org/ttim/pants/builds/117498326

ST
  1. 
      
  2. Might be better to have Artifact expose a fingerprint method, because that puts the marking of "important properties" on the object, rather than over here.

    1. I was confused by wiki field, done.

  3. 
      
BE
  1. Same comment as Stu: Why not add fingerprint() to WikiArtifact?

    1. Done, better this way, thanks.

  2. 
      
TA
BE
  1. Ship It!
  2. 
      
TA
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as d5390d582400eda823cdb70c32bd6913aa60435d

Loading...