Do not return directories from BUILD file's globs implementation

Review Request #3590 - Created March 21, 2016 and submitted

Information
Timur Abishev
pants
tabishev/jvmapp_hash_issue
3068
Reviewers
pants-reviews
benjyw, nhoward_tw, stuhood, zundel

I've discovered fingerprint method fails on jvm_app targets because of pants globs implementation returns folders which are not hashable. I think it's fair enough to return only files in globs/rglobs/zglobs implementations for BUILD files. This PR contains tests for both jvm_app fingerprint and globs behaviour + fix for it.

https://travis-ci.org/ttim/pants/builds/117934043

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Stu Hood
Eric Ayers
Timur Abishev
Eric Ayers
Benjy Weinberger
Timur Abishev
Benjy Weinberger
Timur Abishev
Eric Ayers
Timur Abishev
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 2af4f6c53f0a7391111d7949c44f9a59cd1f407d

Loading...