Re-add the ConsoleRunnerOutputTests and consolodate them into ConsoleRunnerTest, also move test clases used for testing into junit/lib directory

Review Request #3588 - Created March 19, 2016 and submitted

Information
Chris Heisterkamp
pants
readd-console-runner-command-line-tests
3067
Reviewers
pants-reviews
gmalmquist, patricklaw, stuhood, zundel
Re-add the ConsoleRunnerOutputTests and consolodate them into ConsoleRunnerTest, also move test clases used for testing into junit/lib directory

Travis CI: https://travis-ci.org/pantsbuild/pants/builds/117841276

This re-adds most of the changes from https://rbcommons.com/s/twitter/r/2406/ to make the swappable streams non-static in ConsoleRunnerImpl and testable.

It also moves all the Test classes that are only used to test the ConsoleRunnerImpl into src/java/org/pantsbuild/tools/junit/lib so they are under a java_library() target and do not get run as regular tests under junit/impl. It updates the java packages so they match the directory the are in.

Finally, it renames ConsoleRunnerTestHelper to ConsoleRunnerTestBase and consolodates the ConsoleRunnerOutputTests into ConsoleRunnerTest.

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Chris Heisterkamp
Eric Ayers
Stu Hood
Chris Heisterkamp
Eric Ayers
Chris Heisterkamp
Eric Ayers
Chris Heisterkamp
Review request changed

Status: Closed (submitted)

Loading...