Speed up node repl integration test by using smaller targets

Review Request #3584 - Created March 18, 2016 and submitted

Information
Nick Howard (Twitter)
pants
3062
Reviewers
pants-reviews
jsirois

The test_run_repl_multiple_targets test takes about a minute to run due to it's dependency on contrib/node/examples/src/node/preinstalled-project. That target pulls down a large number of transitive dependencies.

This changes the test to use a different smaller target as the second target, dropping the test time to ~10 seconds.

Ran test locally with changes using the pytest --duration flag and saw the change in time.

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Stu Hood
Stu Hood
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/acbeb56f1834c6f79996f398dd01d3f838fdd473

Eric Ayers

Just made a new release internally- thanks a million for this!

Loading...