Speed up node repl integration test by using smaller targets

Review Request #3584 — Created March 18, 2016 and submitted

nhoward_tw
pants
3062
pants-reviews
jsirois

The test_run_repl_multiple_targets test takes about a minute to run due to it's dependency on contrib/node/examples/src/node/preinstalled-project. That target pulls down a large number of transitive dependencies.

This changes the test to use a different smaller target as the second target, dropping the test time to ~10 seconds.

Ran test locally with changes using the pytest --duration flag and saw the change in time.

  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
  1. 
      
  2. I'm confused... it looks like this just changed the name of the target, but that the same target is still being used?

    1. It changed from the server-project, which pulls in many external dependencies to the preinstalled-project, which has fewer. It also fixes an issue with preinstalled-project's package.json which looks like it was copied from server-project.

    2. Ah, derp. Was reading the package.json and thinking it was a BUILD file.

  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/acbeb56f1834c6f79996f398dd01d3f838fdd473

  1. Just made a new release internally- thanks a million for this!

  2. 
      
Loading...