[engine] skip caching for native nodes

Review Request #3581 - Created March 17, 2016 and submitted

Information
Peiyu Wang
pants
3057
Reviewers
pants-reviews
kwlzn, patricklaw, stuhood

Native nodes should not be cached.

This review

  • Introduces a _should_cache method in Engine which has one predicate today based on Node type.
  • An items() interface for testing purpose, to allow iterate over all cached key, values.

https://travis-ci.org/peiyuwang/pants/builds/116753207

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Stu Hood
Peiyu Wang
Kris Wilson
Peiyu Wang
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 0dbdf54e86b7285ceb08c62c5183d6362e285788

Loading...