[engine] Add support for directory matches to PathGlobs, and use for inference

Review Request #3567 — Created March 12, 2016 and submitted

stuhood
pants
3024, 3042
pants-reviews
kwlzn, patricklaw, peiyu
  • Allow FilesystemNode to recurse to compute a value.
  • Split FileContent and FilesContent back apart in order to support lookups for individual Path objects.
  • Reenable dependency inference by preserving directory names, and differentiating betweem files and dirs via an os.sep suffix.

https://travis-ci.org/pantsbuild/pants/builds/115749339

  1. lgtm!

  2. src/python/pants/engine/exp/fs.py (Diff revision 1)
     
     

    kill initialization here in favor of branching logic below?

  3. src/python/pants/engine/exp/nodes.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    nice.

  4. src/python/pants/engine/exp/nodes.py (Diff revision 1)
     
     

    nit: indent alignment

  5. 
      
  1. 
      
  2. src/python/pants/engine/exp/fs.py (Diff revision 1)
     
     

    leave it as _ private

  3. src/python/pants/engine/exp/fs.py (Diff revision 1)
     
     

    make this a property of path_literal.isdir so only parse_spec deals with os_sep?

  4. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as cd9f387c7261139e9ac1ac86e0319d8ac73b929c

Loading...