[pantsd] Add support for fetching watchman via BinaryUtil.

Review Request #3557 - Created March 10, 2016 and submitted

Information
Kris Wilson
pants
kwlzn/pantsd/watchman_binary
3031
Reviewers
pants-reviews
jsirois, nhoward_tw, peiyu, stuhood
  • Add BinaryUtil support for WatchmanLauncher.
  • Decouple WatchmanLauncher from FSEventService in favor of cleaner usage in PantsDaemonLauncher.
  • Implement testable_memoized_property in support of setting of memoized_property properties for testing.
  • Special case the removal of --watchman-path in favor of BinaryUtil-style options - don't think we need a deprecation cycle for this due to the experimental nature of current watchman support.
  • Test refactoring.

https://travis-ci.org/pantsbuild/pants/builds/115144084

+ additional manual testing

Stu Hood
Stu Hood
Peiyu Wang
Kris Wilson
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

thanks gents! submitted @ 1299ddece5d6cb45adbe5ab797f1a151e8430196

Loading...