Deprecate version_filter from python_requirement

Review Request #3545 - Created March 8, 2016 and submitted

Information
Peiyu Wang
pants
3019
3494
Reviewers
pants-reviews
kwlzn, patricklaw, stuhood

I ran into this long time TODO while working on the new engine: lambda is not picklable.

Discussed with group, looks like we can deprecate version_filter field.
The alternative to keep the option and parse the format using Interpreter.matches is
also discussed, but we don't find a compelling reason to continue support this rarely
used field. Given our interpreter_requirement=CPython>=2.7,<3, the only use case about
unittest2 is assumed.

Ideally we want to follow the similar deprecation cycle we have for cmdline options, I
am not sure how to do this for an optional field.

https://travis-ci.org/peiyuwang/pants/builds/114402900 passed
https://travis-ci.org/pantsbuild/pants/builds/114429073 passed

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Stu Hood
Kris Wilson
Stu Hood
Peiyu Wang
Stu Hood
Patrick Lawson
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 7893d541b857d0fe9d57b904421b51cce937da6f

Loading...