Reimplement list options to support appending.

Review Request #3541 - Created March 7, 2016 and submitted

Information
Benjy Weinberger
pants
Reviewers
pants-reviews
jsirois, patricklaw, stuhood, zundel

[To releasers: See end of this message for things to call out in release notes]

To append a single value to a list-valued option, just "set" the option
to that value, as with action='append'.

./pants --foo=1 --foo=2

To append several values, add a plus sign in front of the value:

./pants --foo=+\[1,2\]

To replace the existing value, just set to a list:

./pants --foo=\[1,2\]

Note that this syntax works with config and env values as well. This
means that you can append to the value specified in, say, pants.ini,
but also override it entirely, if you need to.

This endows list_option with the only useful feature of action='append', which
will therefore soon be deprecated. In fact, action='append' is now implemented
as a list_option under the covers, so replacing all uses of it should be
straightforward.

In order to support lists of values other than strings, this change
introduces a member_type registration arg, which is only valid when
type=list_option.

This change was more complex than you'd think, as it required refactoring
Parser._compute_value. That method is now clearer and better documented
than before.

Some behavior has changed slightly. E.g., previously we validated
values even if they weren't used (e.g., the config, when it was overridden
by a cmd-line flag). Now we only validate the actual final value. But
these changes are either positive or neutral, in terms of their impact,
and they make the code more straightforward.

Release notes should also call out the following:

  • This commit tightens up some aspects of option type conversion. There may be options
    in plugins that were relying on broken behavior (such as when using a string where an
    int was expected), and that will now (correctly) break.
  • This commit deprecates the PANTS_DEFAULT_* env vars in favor of PANTS_GLOBAL_*.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/114384803

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Stu Hood
Benjy Weinberger
Eric Ayers
Benjy Weinberger
Eric Ayers
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

7f1403ef9c8289719620cc44b33a85deb232f75e

Loading...