Extract ivy usage from IvyTaskMixin into IvyUtils

Review Request #3539 — Created March 6, 2016 and discarded

stuhood
pants
2239, 3013
pants-reviews
gmalmquist, jsirois, nhoward_tw, patricklaw

To prepare to begin using Ivy from places other than the existing Task API, this extracts the meat of ivy resolution into IvyUtils. This has the benefit of a significantly smaller API on IvyUtils, and thus results in a lot of deprecations.

@Nick: I know you've been working in here: if this looks like it's going to obliterate your patches, feel free to tell me to take a hike until after that has landed.

  • Move do_resolve and load_resolve into IvyUtils with IvyResolveRequest/IvyResolveResult objects as API.
  • Deprecate all methods of IvyUtils that were used only in IvyTaskMixin.

https://travis-ci.org/pantsbuild/pants/builds/114321421

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Doing this work is only necessary if we are going to do a resolve rather than a load. Maybe move ... NH nhoward_tw
ST
ST
ST
NH
  1. Looks pretty good. One note.

  2. src/python/pants/backend/jvm/tasks/ivy_task_mixin.py (Diff revision 3)
     
     
     
     
     

    Doing this work is only necessary if we are going to do a resolve rather than a load. Maybe move it to do_resolve?

  3. 
      
ST
  1. Based on offline discussion, Nick is going to incorporate (something like) this into the review he's posting this week.

  2. 
      
ST
Review request changed

Status: Discarded

Change Summary:

Based on offline discussion, Nick is going to incorporate (something like) this into the review he's posting this week.

Loading...