Lock ivy resolution based on the cache directory being used.

Review Request #3529 - Created March 2, 2016 and submitted

Information
Patrick Lawson
pants
3000
Reviewers
pants-reviews
benjyw, jsirois, nhoward_tw, stuhood, zundel

This strategy uses a cross-process file lock. Since
there are no reentrant uses of ivy execution (nor should
there be), there is no potential for deadlock.

This is less performant than using a separate directory
for resolution reporting than the directory used for
artifact downloading, but no worse if the user is
already configured to use a non-global cache.

Travis: https://travis-ci.org/pantsbuild/pants/builds/113293163

All existing ivy tests pass, which exercise both resolution
code paths that this code affects. Jenkins passed on fresh
machines with no ivy errors (a first) with this patched in.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Nick Howard (Twitter)
Benjy Weinberger
Benjy Weinberger
Patrick Lawson
Patrick Lawson
Review request changed

Status: Closed (submitted)

Change Summary:

Commit 3d2cf5d8a1d4aa70ad595675aefd7a63899c8510

Loading...