Make synthetic jar_library targets dependencies of android_binary.

Review Request #3526 - Created March 2, 2016 and submitted

Information
Mateo Rodriguez
pants
2993, 2994
Reviewers
pants-reviews
jsirois, molsen, patricklaw

There are a few other small fixes here to make all the
android tests go green as a prelude to moving android
into contrib.

AndroidLibrary targets are just ways to attach resources to jars
and optionally define include/exclude patterns. So any
AndroidBinary thats depends on an AndroidLibrary should
get the libraries classes.jar on its classpath for free.

All of the android-specific tasks already have the logic
to pull the entire closure into Android tasks. But jvm_compile
doesn't have that special logic. So directly attaching the
classes.jar dependency to the binary is the simplest
way forward.

With this commit, all the android tests go green and
./pants bundle examples/src/android::` runs succeessfully.

Closes: 2993

All android tests now are green again (including integration) and the example projects all build.
Re-triggered the CI to test on green master: https://travis-ci.org/pantsbuild/pants/builds/114286953

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Mateo Rodriguez
Stu Hood
Mateo Rodriguez
Mateo Rodriguez
Mateo Rodriguez
Mateo Rodriguez
Mateo Rodriguez
Stu Hood
Mateo Rodriguez
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks - this is submitted as: 3af259596a444f9beb71089ee936cadfad7a729f

Loading...