Reset Subsystems when creating a new context in tests

Review Request #3496 - Created Feb. 24, 2016 and submitted

Information
Nick Howard (Twitter)
pants
2960
Reviewers
pants-reviews
benjyw, jsirois, stuhood, zundel
Subsystem instances may cache options values, so it's not sufficient to just assign to Subsystem._options, we also need to clear out the subsystem instances.

This change causes context creation to clear the global subsystems, and fixes the one test that had issues with doing so to use options rather than reaching into the subsystem instance directly.

This resolved some mysterious issues in a patch I've been working on. CI's also away on the associated PR.

Eric Ayers
Benjy Weinberger
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/586c64198418748c1517a2456705f6b5c000c8c7

Loading...