the checkstyle task should not need the runtime classpath to run checkstyle

Review Request #3487 - Created Feb. 23, 2016 and submitted

Information
Chris Heisterkamp
pants
cheister/checkstyle-does-not-need-runtime-classpath
2950
Reviewers
pants-reviews
kwlzn, nhoward_tw, patricklaw, stuhood, zundel
the checkstyle task should not need the runtime classpath to run checkstyle

Locally these changes work with our checkstyle configuration at Square and let's us run the Checkstyle step before compilation via

  task(name='checkstyle', action=Checkstyle).install('compile', first=True)

Travis CI is also passing: https://travis-ci.org/pantsbuild/pants/builds/111099344

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Stu Hood
Chris Heisterkamp
Stu Hood
Eric Ayers
Chris Heisterkamp
Review request changed

Status: Closed (submitted)

Eric Ayers

Thanks for the patch Chris! I committed this to master @ 4b34617 . I already marked this review as submitted, but could you please close the associated github issues (and mention this commit sha)

Eric Ayers
Ship It!
Loading...