fix pathdeps for synthetic targets.

Review Request #3454 - Created Feb. 11, 2016 and submitted

Information
Matt Olsen
pants
2917
Reviewers
pants-reviews
benjyw, jsirois, patricklaw, stuhood

fix pathdeps for synthetic targets.

A problem surfaced at twitter where pathdeps failed for when it hit the scala style synthetic
target. This change explicitly checks to see if a target was synthetic which seems to have
been the intent of the attribute check.

CI green: https://travis-ci.org/pantsbuild/pants/builds/108651680

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Matt Olsen
Stu Hood
Matt Olsen
Timur Abishev
Nick Howard (Twitter)
Stu Hood
Peiyu Wang
Fedor Korotkov
Matt Olsen
Review request changed

Status: Closed (submitted)

Change Summary:

commit 1319b2f86b0d940f8340e0fa0c1d10224f1a56c5

Peiyu Wang

   
  1. expected declared but not used?
  2. return order isn't guaranteed we might see flaky test
  1. This is assert_consol_output:

    def assert_console_output(self, output, *kwargs):
    """Verifies the expected output entries are emitted by the console task under test.

    NB: order of entries is not tested, just presence.
    
    :API: public
    
    *output:  the expected output entries
    **kwargs: additional kwargs passed to execute_console_task.
    """
    self.assertEqual(sorted(output), sorted(self.execute_console_task(**kwargs)))
    

    Since these are sorted we shouldn't see any flaky results.

Loading...