Make IvyTaskMixin.ivy_resolve private, introduce ivy_classpath; clean up some ivy resolve tests

Review Request #3450 - Created Feb. 11, 2016 and submitted

Information
Nick Howard (Twitter)
pants
2913
Reviewers
pants-reviews
benjyw, jsirois, stuhood, zundel
ivy_resolve does too many things and exposes results that aren't used by callers outside of IvyTaskMixin. This change introduces a new entrypoint for just resolving the classpath and makes ivy_resolve private.

With this, we can more easily change IvyTaskMixin's internals because they are better encapsulated.

CI on PR.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Benjy Weinberger
Benjy Weinberger
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Benjy! https://github.com/pantsbuild/pants/commit/369da95dc6f4dd7b3d67b7b2cc9fb82b32457eb0

Loading...