Skip hashing in ivy fingerprint strategy if target doesn't need fingerprinting

Review Request #3447 — Created Feb. 10, 2016 and submitted

nhoward_tw
pants
2911
pants-reviews
benjyw, jsirois, stuhood, zundel
This change makes it so that we don't perform any work if the passed target would return None anyway.

CI passed at https://travis-ci.org/pantsbuild/pants/builds/108668708

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
PE
  1. Ship It!
  2. 
      
BE
  1. Ship It!
  2. 
      
ST
  1. 
      
  2. This seems likely to go out of sync with the checks below. Can they be unified into one check somehow?

    1. I think that's possible. I'll work something up.

  3. 
      
PA
  1. 
      
  2. This is a major regression--now you're returning a real hash even when the JvmTarget isn't contributing to the hash. The return None still needs to happen if the target is a JvmTarget but doesn't have excludes.

    1. Thanks for the catch. I'm going to play with some examples and add some unit tests around fingerprinting.

  3. 
      
NH
NH
ST
  1. Ship It!
  2. 
      
NH
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted at https://github.com/pantsbuild/pants/commit/bc03a98e3086793af25f0ce5fde068932052344d

Loading...