Andrew Hamilton got a fish trophy!

Adds support for golang meta info for imports

Review Request #3443 - Created Feb. 9, 2016 and submitted

Information
Andrew Hamilton
pants
ahamilton55:ah/golang_meta_archive_fetcher
2907
Reviewers
pants-reviews
benjyw, jsirois

Adds support for golang meta info for imports

- Adds a check for meta information for golang imports
- Passes additional information to the archive fetcher to properly
download imports that use meta info (e.g. google.golang.org)

This fixes imports such as google.golang.org/api/googleapi which utilize the meta tag to change the root of unzip in the $GOPATH as well as actual repository location.

Part of this GH issue: https://github.com/pantsbuild/pants/issues/2378

Tested with my own repo so far.

Looked at the tests for this part of the code and couldn't figure out how to fit it in properly. Not totally sure what the best path to test this so a pointer in some direction would be helpful.

Issues

  • 0
  • 20
  • 1
  • 21
Description From Last Updated
Andrew Hamilton
Andrew Hamilton
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Andrew Hamilton
Review request changed

Status: Closed (submitted)

Benjy Weinberger

Landed as 7a7f51390cacd82a3e982eaf4516c510f23092c0.

Benjy Weinberger

Done! I also closed the RB. You still need to close the pull request you used to trigger CI.

Also, in the future please add a link to a passing CI under "Testing done" in RB before landing a change.

Thanks!

Loading...